[arm64] enable cycle counter #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| int pmcr_mask = 1; | ||
|
|
||
| __asm__ volatile("msr pmcr_el0, %0":: "r"(pmcr_mask):); |
There was a problem hiding this comment.
Looks good, but need to move it into the percpu routines, so it also gets initialized on more than just the first cpu.
|
Yes, you're right, I will do it and send a v2 pull request when I am back from holiday. |
|
I did another implementation over in magenta that works on all processors. I'll try to merge that back soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Cycle counter is not enable on arm64 arch, so the command line "bench" always return "took 0 cycles".
This patch enable cycle counter, let me know if it's ok or not.