refactor(litmus): adding "ns.svc.cluster.local" to urls #371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding full service fqdn to the end of service urls to assist with proxied environments
What this PR does / why we need it:
In proxied environments, you can get Litmus to operate properly by setting proxies in the environment args. However, the service names are hardcoded just to the service name itself without any FQDN (i.e. "http://litmus-server-service:9002/") which will inadvertently send the traffic through the Proxy.
Typically, in these proxied environments you'd put "cluster.local" in the
no_proxy
setting so internal cluster traffic is not proxied - since the service names are not a full domain path, we run in to issues. This PR appends the standard ".svc.cluster.local" to the nginx pass URLs as well as the DB_SERVER urls so that connection to those services are caught by theno_proxy
settingsWhich issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]