Fix breaks when mongodb subchart is not used #291
Conversation
Signed-off-by: bingwei-hong-partior <[email protected]>
bingwei-hong-partior
requested review from
imrajdas,
ispeakc0de and
Jasstkn
as code owners
Signed-off-by: bingwei-hong-partior <[email protected]>
bingwei-hong-partior
force-pushed
the
fix-litmus-helpers-tpl
branch
from
d19dda0
to
331378e
Compare
|
@bingwei-hong-partior could you provide an example of values and errors - it will help to gather more context around the issue. |
|
when mongodb.enabled is set as true, chart can be rendered properly when mongodb.enabled is set as false, _helpers.tpl will fail to render properly due to subcharts no longer included. This result in unable to use external mongodb instance. subchart dependency have a condition when mongodb.enabled set as false in values.yaml file, mongodb subchart will not be available, result in lint failure as shown below lint shows rendering error both server-deployment.yaml and auth-server-deployment.yaml also using .Values.mongodb.service.ports.mongodb without checking if mongoDB is enabled. @Jasstkn , please let me know if there is a better way of fixing this without doing these changes. May I also ask if there is a way to cater for allow specifying the dependency's repository url? This is to cater for situations where we prefer to pull all the helm repo via our jfrog remote as proxy. In current setup, dependency repo url is hard-coded. |
Signed-off-by: bingwei-hong-partior <[email protected]>
|
Hi Team, could you review and let me know if any concern on this PR. thank you. |
|
@imrajdas , @Jasstkn , @ispeakc0de , could you please review this PR. Let me know if additional information is required. thank you. |
Hi! Sorry for the delayed reply - I'll take a closer look later today. |
Signed-off-by: bingwei-hong-partior <[email protected]>
@Jasstkn , any updates regarding this PR? I am actually needing this PR, otherwise I have to maintain my own fork which is not really something I want to do. |
Signed-off-by: Maria Kotlyarevskaya <[email protected]>
Signed-off-by: Maria Kotlyarevskaya <[email protected]>
| @@ -42,7 +42,11 @@ spec: | |||
| command: ["/bin/sh", "-c"] | |||
| args: | |||
| [ | |||
| {{- if .Values.mongodb.enabled }} | |||
| "while [[ $(curl -sw '%{http_code}' http://{{ include "litmus-portal.mongodbServiceName" . }}:{{ .Values.mongodb.service.ports.mongodb }} -o /dev/null) -ne 200 ]]; do sleep 5; echo 'Waiting for the MongoDB to be ready...'; done; echo 'Connection with MongoDB established'", | |||
There was a problem hiding this comment.
Can we calculate port the same way as we do with name? just move this logic to template and include the result.
| "while [[ $(curl -sw '%{http_code}' http://{{ include "litmus-portal.mongodbServiceName" . }}:{{ .Values.mongodb.service.ports.mongodb }} -o /dev/null) -ne 200 ]]; do sleep 5; echo 'Waiting for the MongoDB to be ready...'; done; echo 'Connection with MongoDB established'", | ||
| {{- else }} | ||
| "while [[ $(curl -sw '%{http_code}' http://{{ include "litmus-portal.mongodbServiceName" . }}:{{ .Values.adminConfig.DB_PORT }} -o /dev/null) -ne 200 ]]; do sleep 5; echo 'Waiting for the MongoDB to be ready...'; done; echo 'Connection with MongoDB established'", |
What this PR does / why we need it:
This is to fix issues when external mongoDB is used (.Values.mongodb.enabled is set as false), result in rendering errors in the few templates.
a few templates.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Have tested both following
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]