-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase to alpine 3.19 and python 3.12 #97
Conversation
Have you tested upgrade scenarios with existing addon packages in /config? |
Existing packages in With that said, I haven't tested it with my production install as an upgrade due to being away from home and not wanting to risk breakage :-) |
@aptalca As I checked my custom integrations and saw that they all should run with 3.12 I deleted the folder /config/lsiopy and restarted with your test build. Everything is up and running now. Thank you very much. |
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
TL;DR: I've tested both AMD64 and ARM64 images based on the py312 branch, and have no issues to report. Only one suggestion for release notes at the bottom. I've been a user of the mainstream linuxserver/homeassistant container for almost a year. Thank you for maintaining this fantastic resource! This is my first dive into the development side of this container image. I recently forked the project and built my own arm64 and amd64 images from the py312 (https://github.com/linuxserver/docker-homeassistant/tree/py312) branch. I then tested it both as a fresh install and as an upgrade to a snapshot of my production system. Environments Tested:
(PROD) ARM64 on Raspberry Pi5 --> Docker Standalone 25.03
Integrations Tested:
One note related to switching from venv back to using /config/.local/lib/python3.12/site-packages: |
oh wow, thanks so much for the detailed report and extensive testing. I was able to reproduce the issue with wyze as well as simpleicons. Funny thing is, I do see that the python packages are indeed installed in the correct folder during that first start:
However, HA does log the errors about missing modules and disables the integrations on that first start. Perhaps HA's logic has changed so that it first checks for existence and decides whether to enable or not, and then installs the modules via pip whereas previously it seemed to check and install any missing manifest dependencies, and then enable the integrations on start. In any case, this is not something in our control and is 100% controlled by upstream's init logic. It could create issues for their official image as well, if a user happens to delete the I will go ahead and add a note in the changelog. |
I am a bot, here are the test results for this PR:
|
🥳 that "YA'LL PYTHON3.11 IS DEAD IT'S DEAD YOU GOTTA UPDATE" message was giving me stupid bad anxiety, so thank you guys so much for releasing this ❤️ |
Use upstream wheels instead of lsio ones
Retrieve python, pip and jemalloc versions from upstream and match
Since python is compiled from source instead of os package, we can do away with the venv. New python packages get installed in the /config folder (user home).
Due to doing away with the venv and breaking cadence with lsio wheels, package installer script also has been customized
Could use a little more testing in production before merge, but needs to be merged by April as that's when HA drops support for py 3.11Tested update of production instance, no issues.
closes #95
When merged (or right before), the following needs done: