Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cinnamenu@json: Update .po files #6297

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

fredcw
Copy link
Contributor

@fredcw fredcw commented Aug 9, 2024

@rcalixte Thanks for updating the po files. I usually remove the comments just so it saves a bit of space though it's probably not important.

fixes: #6299

@rcalixte
Copy link
Member

rcalixte commented Aug 9, 2024

I usually remove the comments just so it saves a bit of space though it's probably not important.

The comments don't end up in the compiled translations (so the size issue is largely only related to cloning the repository and even then, it's on the order of bytes) and they serve as a context aid for translators: image

On top of that, this fights against the automation that will eventually be in place that will revert these removals.

What is the net gain of this?

@rcalixte rcalixte marked this pull request as draft August 9, 2024 19:16
@fredcw
Copy link
Contributor Author

fredcw commented Aug 9, 2024

the size issue is largely only related to cloning the repository and even then, it's on the order of bytes

It adds to the applet download size and the disk space required for the applet, 3.2MB compared to 1.9MB.

they serve as a context aid for translators

That's the intention, yes, but it's hard to say whether translators find them useful or even look at them at all. I guess we'd have to ask them. Comments that just say, for instance, applet.js are probably not that useful but in cinnamenu they're probably more useful since they come from different files: categories.js, contextMenu.js, etc.

I also remove the list of internet search providers and the list of wikipedia languages derived from settings-schema.json as these shouldn't be translated anyway.

I'm happy to keep the comments if translators find them useful but I do need to remove the list of wikipedia languages because I think the list needs to be the same as the one used by wikipedia itself, ie. the language name written in it's own language.

@rcalixte
Copy link
Member

rcalixte commented Aug 9, 2024

It adds to the applet download size and the disk space required for the applet, 3.2MB compared to 1.9MB.

On a 1 Mbps connection, this still amounts to seconds at most. Effectively, this will only be noticeable to users on 2G connections. (3G is around 7 Mbps under normal conditions.) Bandwidth/hosting costs are also negligible. In all, I'm not seeing the need to over-optimize this.

That's the intention, yes, but it's hard to say whether translators find them useful or even look at them at all.

Remove them because they might not be useful... but for what gain? What are the pros and cons here? (And many translators use Poedit (what I used for the screenshot) which displays this by default.)

Comments that just say, for instance, applet.js are probably not that useful but in cinnamenu they're probably more useful since they come from different files: categories.js, contextMenu.js, etc.

The comments also include line numbers, adding context if needed. The entire goal is to aid the translators already volunteering their time.

I'm happy to keep the comments if translators find them useful but I do need to remove the list of wikipedia languages because I think the list needs to be the same as the one used by wikipedia itself, ie. the language name written in it's own language.

I was conflicted on this but doesn't it ultimately make sense for the languages to be translated for the end user who wants to adjust their settings? When I go to a website with language options, they are often displayed as translated, sometimes not. Ultimately, maybe we need to find a way for specific entries in the settings to be excluded. Manually managing these files will ultimately be more laborious than it is worth. That's the whole point of striving to have it be automated.

@fredcw
Copy link
Contributor Author

fredcw commented Aug 10, 2024

@rcalixte I'm happy with this PR as it is. Thanks.

@erwn16
Copy link
Contributor

erwn16 commented Sep 13, 2024

Comments in a po-file will lead to better translations

I translate Cinnamenu@json and Hideable applets into German. Translating the entries of the user interfaces is in the great majority of all cases determined by other entries of a particular user interface (the context), the chosen wording and other aspects. Comments in a po-file, which inform about a multiple use of a translation, facilitate extremely the translation process. I was in this described situation while translating Cinnamenu@json. This is for me the main reason to keep them in a po-file because they support better translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cinnamenu@json: Minor letter case issue
3 participants