Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected]: Fix resizing when adding new feeds #6273

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

philipp-meier
Copy link

When adding a new feed, the method set_size_request is called.
This method increases the height of the dialog, so that the user can see the new line that he has created.

Unfortunately, setting the size request will force the user to leave the window at least as large as the size request (see docs).
This is a problem, if you already have too many feeds and adding another one increases the dialog to a height that is not supported by your monitor.

If that's the case, the user can't add feeds anymore.

Can we use set_default_size instead?
This wouldn't remove the resize-functionality and just add another row with scroll-behavior.


And thanks for this applet! :)

@jake1164

@philipp-meier
Copy link
Author

philipp-meier commented Aug 2, 2024

I just noticed that the applet does not support having more feeds that exceed the available screen height.
If that's the case, the FeedDisplayMenuItems can't be expanded anymore.

By adding a vertical scrollbar with the following commit to my fork, I was able to fix it for me:
e3ed645f3f3ad401c2c5c398963304ef8b4b7051

If someone is interested, I can also add this to the PR or create a new PR for the additional scrollbar.
I am not sure whether the solution is sustainable though, since I do not have any experience with GJS and just tried to get a working solution/workaround.

Edit:
I have been using the mentioned commit on a daily basis without any problems for about 2 months now.

@rcalixte
Copy link
Member

cc @jake1164 if you have any thoughts or feedback on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants