Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xx30 boards: fixing CONFIG_CBFS_SIZE=0x710000 for x230 and t430 boards #821

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

tlaurion
Copy link
Collaborator

@tlaurion tlaurion commented Sep 1, 2020

Probable fix for #815 and #667

@tlaurion
Copy link
Collaborator Author

tlaurion commented Sep 1, 2020

Build was successful: https://app.circleci.com/pipelines/github/tlaurion/heads/360/workflows/f32d840f-6dfb-4904-ac19-98d2870cae47/jobs/388

Roms testable direct links:
x230: https://388-103208611-gh.circle-artifacts.com/0/build/x230/coreboot.rom
t430: https://388-103208611-gh.circle-artifacts.com/0/build/t430/coreboot.rom

@TrapAcid @nickfrostatx @lsafd @bwachter
Please follow : #815 (comment)
Above CircleCI builds are fixing CBFS. This is what we want to test upon a ME cleaning as per above referred instructions.

Please report back success/failing.
@flawedworld : if you have anything to add, please advise.

@tlaurion
Copy link
Collaborator Author

tlaurion commented Sep 1, 2020

Note: 710000 is the maximum size possible without modifying IFD to maximize BIOS region consequently of having reduced ME region, following this thread #667 (comment)

@tlaurion
Copy link
Collaborator Author

tlaurion commented Sep 1, 2020

x230: https://388-103208611-gh.circle-artifacts.com/0/build/x230/coreboot.rom
Tested and works as expected. Waiting for someone to confirm that the PR works on the t430 and fixes the issue.

@ghost
Copy link

ghost commented Sep 2, 2020

Will test t430 config this evening.

@tlaurion
Copy link
Collaborator Author

tlaurion commented Sep 2, 2020

@TrapAcid result?

@ghost
Copy link

ghost commented Sep 2, 2020

@tlaurion t430 CBFS size change to 0x710000 worked successfully.

@tlaurion tlaurion merged commit ef96d64 into linuxboot:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant