Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network-init-recovery script: Request IP from DHCP, NTP time #706

Merged
merged 1 commit into from
May 24, 2020
Merged

network-init-recovery script: Request IP from DHCP, NTP time #706

merged 1 commit into from
May 24, 2020

Conversation

tlaurion
Copy link
Collaborator

@tlaurion tlaurion commented Apr 22, 2020 •
edited
Loading

  • Adds the missing piece so IP is requested from DHCP if IP not defined in board
  • Then sync time from DNS server provided by DHCP prior of attempting sync from pool.ntp.org

@tlaurion tlaurion force-pushed the network-init-recovery_dhcp-ntp branch from c28612e to 01dabe1 Compare April 22, 2020 19:01
@tlaurion
Copy link
Collaborator Author

tlaurion commented Apr 22, 2020 •
edited
Loading

This is a good way to test #700 on other platforms (tagged you from information from #692 ) to know if the problem arises with other ethernet card and modules attempted in the script from master.

Please report for the board tested:
x220 (xx20): @SebastianMcMillan @techge @eganonoa @shamen123
t420 (xx20): @SebastianMcMillan: others?
t430 (xx30): @flawedworld? others?
x230 (xx30): @tlaurion @osresearch @merge @jan23 @flawedworld @MrChromebox @shamen123 @eganonoa
kgpe-d16 (AMD fam15h) (dropped in coreboot 4.11): @tlaurion @Tonux599 others?
Supermicro x11ssh: @osresearch @citypw @MrChromebox others?
Leopard OCP node: @osresearch others?
Winterfell OCP node: @osresearch others?
Intel S2600wf : @osresearch others?
r630: @osresearch others?
p8h61m-pro: @shamen123

Thanks

@MrChromebox
Copy link
Contributor

@tlaurion the Librem laptops don't have an ethernet port, so this is N/A for them

@tlaurion tlaurion mentioned this pull request Apr 23, 2020
Merged
@tlaurion
Copy link
Collaborator Author

@flammit any opposition? If no answer, will merge in the next days,

@tlaurion tlaurion merged commit 4245aec into linuxboot:master May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flammit flammit Awaiting requested review from flammit

@kylerankin kylerankin Awaiting requested review from kylerankin

@osresearch osresearch Awaiting requested review from osresearch

Assignees

@flammit flammit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tlaurion @MrChromebox @flammit