Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added board target/config and script for downloading blobs for Nvidia K2100m dGPU #1606

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TrustExecutor
Copy link

new file: blobs/w541/vbios_w541_k2100m.sh
new file: boards/UNTESTED-w541-dgpu-k2100m-hotp-maximized/UNTESTED-w541-dgpu-k2100m-hotp-maximized.config
new file: boards/UNTESTED-w541-dgpu-k2100m-maximized/UNTESTED-w541-dgpu-k2100m-maximized.config
new file: config/coreboot-w541-dgpu-k2100m-maximized.config

	new file:   boards/UNTESTED-w541-dgpu-k2100m-hotp-maximized/UNTESTED-w541-dgpu-k2100m-hotp-maximized.config
	new file:   boards/UNTESTED-w541-dgpu-k2100m-maximized/UNTESTED-w541-dgpu-k2100m-maximized.config
	new file:   config/coreboot-w541-dgpu-k2100m-maximized.config
@tlaurion
Copy link
Collaborator

tlaurion commented Feb 15, 2024

@TrustExecutor cleaned your PR for it to build from CircleCI at https://github.com/tlaurion/heads/tree/w541-dgpu

What you report with backup rom having different hashes for dgpu blobs vs downloaded is something. This is a first attempt to make sure we talk about the same results and to remove anything linked to artifacts from your host build station (so Making CI build roms from expected downloaded stuff). Please test CI produced rom and report back. If possible, cherry-pick commits from that branch and push in this PR. Commits need to be signed (commit --signoff) so that DCO step doesn't fail here. I built locally but cannot test.

  • Is the EXE downloaded from lenovo latest available?
  • Didnt compare with w530, but as you can see dgpu boards are not reported tested for a while
  • Things changed in the past and to be honest I lost track of what was the status. You can check around when boards have been moved to UNTESTED to see what was needing testing with and report here on what is thought missing
  • What I quickly seen is that libgfxinit is turned off (desired for dgpu boards) but not sure what happens with bootsplash
  • Laptop beeping (BEEP OF DEATH and flashing under coreboot is linked to memory init failing normally. That is something. Weird that that happens only when dgpu is hybrid

That's all I have for now.

@tlaurion
Copy link
Collaborator

tlaurion commented Feb 18, 2024

NRI (not using mrc for raminit) may be needed as stated under #1607 (comment) @TrustExecutor

@tlaurion tlaurion marked this pull request as draft March 25, 2024 20:31
@tlaurion
Copy link
Collaborator

@TrustExecutor put as draft meanwhile

@tlaurion
Copy link
Collaborator

tlaurion commented Jul 30, 2024

@TrustExecutor please rebase on master and lead next steps based on prior comments at #1606 (comment).

Is that abandoned effort and should be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants