Rebased X230 maximized fhd (edp connector based mods) #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise binary patches cannot be patched/created Additional fixes needed - flashrom patch was invalid and got catched by git apply. Correcting - gpg2-2.2.21.patch was pointing to bad target. Correcting
- add x230-maximized-fhd_edp and x230-hotp-maximized-fhd_edp board configs - add/rework coreboot patch for x230 fhd variant to be applied on top of 4.13 - add coreboot config to point to x230-edp variant, fixing path to vbt file since default path is wrong under. Comment made upstream https://review.coreboot.org/c/coreboot/+/28950/22#message-4904ce82f01ba0505b391e072e4537b6a9f1a229 - remove no gfx init and replace with libgfxinit(defonfig default), set internal display as default - add x230-hotp-maximized-fhd_edp and x230-maximized-fhd_edp to CircleCI builds
Rebase PR 967
|
First time pulling a PR into a branch to be rebased, let me know if something didn't pull right |
|
@echo-84 thanks for the reminder. I guess I should rebase #967 on master ;) will try to do tomorrow or otherwise monday. Otherwise 2 unneeded commits from this PR. |
|
Got it, I'll go ahead and close this PR and leave a note on what I changed to get it working on #967 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #1201 having been merged, rebased #967 on master.
Compiled and flashed to hardware successfully