Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial import of systemd role content #9

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

msekletar
Copy link
Collaborator

No description provided.

@msekletar msekletar force-pushed the systemd-role branch 2 times, most recently from a684637 to 3879a9f Compare July 18, 2023 16:20
@msekletar msekletar changed the title Initial import of systemd role content feat: initial import of systemd role content Jul 18, 2023
@richm
Copy link
Contributor

richm commented Jul 18, 2023

please ignore the ansible-test error ansible-community/ansible-test-gh-action#64

tests/tests_basic.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tasks/main.yml Outdated Show resolved Hide resolved
tests/tests_facts.yml Outdated Show resolved Hide resolved
README-ansible.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
library/systemd_units.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tasks/main.yml Outdated Show resolved Hide resolved
tasks/main.yml Show resolved Hide resolved
tasks/main.yml Show resolved Hide resolved
tests/roles/caller/tasks/main.yml Outdated Show resolved Hide resolved
tests/roles/caller/vars/main.yml Outdated Show resolved Hide resolved
tasks/main.yml Outdated Show resolved Hide resolved
@msekletar
Copy link
Collaborator Author

Updated. @richm @spetrosi PTAL.

tasks/main.yml Outdated Show resolved Hide resolved
tasks/main.yml Outdated Show resolved Hide resolved
tasks/main.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tests/tests_facts.yml Outdated Show resolved Hide resolved
tests/tests_basic.yml Outdated Show resolved Hide resolved
tests/tests_basic.yml Outdated Show resolved Hide resolved
@spetrosi
Copy link
Contributor

[citest]

tests/tests_basic.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@3e5636a). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 75c56fe differs from pull request most recent head cdddeab. Consider uploading reports for the commit cdddeab to get more accurate results

Additional details and impacted files
@@         Coverage Diff         @@
##             main   #9   +/-   ##
===================================
  Coverage        ?    0           
===================================
  Files           ?    0           
  Lines           ?    0           
  Branches        ?    0           
===================================
  Hits            ?    0           
  Misses          ?    0           
  Partials        ?    0           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@msekletar
Copy link
Collaborator Author

Updated. @spetrosi @richm PTAL.

Thank you for bearing with me and my silly mistakes during this review. It is much appreciated!

tasks/main.yml Outdated Show resolved Hide resolved
@msekletar
Copy link
Collaborator Author

Updated.

@richm
Copy link
Contributor

richm commented Jul 20, 2023

[citest]

@msekletar
Copy link
Collaborator Author

@richm I had one more issue with the tests. Can you please rerun CI tests? They should hopefully pass now.

@richm
Copy link
Contributor

richm commented Jul 20, 2023

[citest]

@richm richm merged commit 3e8c14e into linux-system-roles:main Jul 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants