test: use pvcreate with a timeout and verbose logging #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the pvcreate call gives us problems, and different problems on different platforms. Use `timeout 30s` to avoid hangs when it tries to read from stdin. Use verbose `-vvv` to figure out why it hangs/fails. Use `-y` to make it not ask questions and continue anyway. Signed-off-by: Rich Megginson <[email protected]>
|
[citest] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #476 +/- ##
==========================================
- Coverage 16.54% 10.73% -5.81%
==========================================
Files 2 8 +6
Lines 284 1946 +1662
Branches 79 0 -79
==========================================
+ Hits 47 209 +162
- Misses 237 1737 +1500
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the pvcreate call gives us problems, and different problems on different
platforms. Use
timeout 30sto avoid hangs when it triesto read from stdin. Use verbose
-vvvto figure out why ithangs/fails. Use
-yto make it not ask questions and continueanyway.
Signed-off-by: Rich Megginson [email protected]