fix: use stat.pw_name, stat.gr_name instead of owner, group #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cause: The fields `stat.owner` and `stat.group` do not exist. Consequence: The crypttab was always being set to owner/group root. Fix: Use the correct fields `stat.pw_name` and `stat.gr_name`. Result: Owner and group of crypttab are preserved. See https://docs.ansible.com/ansible/2.9/modules/stat_module.html#return-stat/gr_name Signed-off-by: Rich Megginson <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
- Coverage 13.67% 12.00% -1.68%
==========================================
Files 8 8
Lines 1733 1733
Branches 79 0 -79
==========================================
- Hits 237 208 -29
- Misses 1496 1525 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause: The fields
stat.ownerandstat.groupdo not exist.Consequence: The crypttab was always being set to owner/group root.
Fix: Use the correct fields
stat.pw_nameandstat.gr_name.Result: Owner and group of crypttab are preserved.
See https://docs.ansible.com/ansible/2.9/modules/stat_module.html#return-stat/gr_name
Signed-off-by: Rich Megginson [email protected]