Don't fail when it wasn't possible to fetch the interface name. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On which systems do you see the |
|
It's Android. I've built the kernel (4.4) by myself, so there is a chance I misconfigured something. It's clearly a problem with my system, but it's hard to say if it's tied to Android P or my specific device. I'd appreciate help debugging this, but the patch with workaround has still some value, because any other Android developer may hit the issue at other time. |
On some systems SIOCGIFNAME may fail with ENOTTY, but the actual slcanX interface gets properly configured. Instead of crashing hard on such case, let's gracefuly degrade and just not display the interface name.
twasilczyk
force-pushed
the
slcand-android
branch
from
af93051
to
bda50c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems
SIOCGIFNAMEmay fail withENOTTY, but the actualslcanXinterface gets properly configured. Instead of crashing hardon such case, let's gracefuly degrade and just not display the
interface name.
This is the issue I mentioned in #118