Remove WidgetState::Cursor
#710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
approved these changes
Oct 22, 2024
masonry/src/widget/widget.rs
Outdated
| fn get_cursor(&self) -> CursorIcon { | ||
| /// Return the cursor icon for this widget. | ||
| /// | ||
| /// **pos** - the position in global coordinates (e.g. `(0,0)` is the top-left corner of the |
There was a problem hiding this comment.
the position of what? I presume the mouse?
| // TODO - Add &UpdateCtx argument | ||
| fn get_cursor(&self) -> CursorIcon { | ||
| /// Return the cursor icon for this widget. | ||
| /// |
There was a problem hiding this comment.
Should this mention cursor_icon_changed here?
Tweak docs.
DJMcNab
approved these changes
Oct 22, 2024
| // TODO - Document | ||
| // TODO - Add &UpdateCtx argument | ||
| fn get_cursor(&self) -> CursorIcon { | ||
| /// Return the cursor icon for this widget. |
There was a problem hiding this comment.
We should document when this will be called here as well, i.e. something like when the mouse cursor moves. It may also be called due to cursor_icon_changed, for cases when the state under the cursor might have changed (consider for example a link moving under the cursor due to a keypress in a rich text box)
There was a problem hiding this comment.
I think I'll re-write the doc in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.