Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial code from Vello. #1

Merged
merged 34 commits into from
Mar 11, 2024
Merged

Add initial code from Vello. #1

merged 34 commits into from
Mar 11, 2024

Conversation

simbleau
Copy link
Member

@simbleau simbleau commented Mar 9, 2024

This PR initializes the repo to a basic state.

@simbleau simbleau changed the title Initial seed repo Draft: Initial seed repo Mar 9, 2024
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had time to only quickly skim a few files, but I already have a few comments inline.

The unifying idea of my complaints is that I think we should stick more closely to established Linebender culture. Not to say that these things are unchangeable forever, but at the very least this initial seed is the wrong place to start changing such things.

.github/dependabot.yml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
rustfmt.toml Outdated Show resolved Hide resolved
Co-authored-by: Kaur Kuut <[email protected]>
@simbleau
Copy link
Member Author

simbleau commented Mar 9, 2024

I had time to only quickly skim a few files, but I already have a few comments inline.

The unifying idea of my complaints is that I think we should stick more closely to established Linebender culture. Not to say that these things are unchangeable forever, but at the very least this initial seed is the wrong place to start changing such things.

They were good comments, thanks for the initial review.

@simbleau simbleau requested a review from xStrom March 9, 2024 15:01
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's another pass. Might have missed something, because looks like the fork wasn't based on the freshest main of the Vello repo. Although I guess we don't necessarily need all of that, like vello#435?

AUTHORS Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
.github/copyright.sh Outdated Show resolved Hide resolved
.github/copyright.sh Outdated Show resolved Hide resolved
.github/workflows/pages-release.yml Outdated Show resolved Hide resolved
examples/run_wasm/src/main.rs Outdated Show resolved Hide resolved
examples/scenes/Cargo.toml Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've reached a state where this can be merged. 🎉

Before merging, I'll note two things:

  • The PR title should be changed (I'll just do it myself in a second)
  • Use the Squash Merge option to do the merge, as that is the Linebender way

Thanks for putting in the effort to get this landed!

@xStrom xStrom changed the title Draft: Initial seed repo Add initial code from Vello. Mar 11, 2024
@simbleau simbleau merged commit 3d1d99d into main Mar 11, 2024
9 checks passed
@simbleau simbleau deleted the initial-seed branch March 11, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants