Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test draws lines with very large floating point y-coordinates (spanning
12345678901234567890.0
and-9.8765432109876543210e+19
respectively). This causes an overflow in bump estimation and results in rendering issues in Vello.Bump Estimation
This test causes a panic in debug builds with the bump_estimate feature enabled:
This happens because the line generates an exorbitant amount of tile crossings which causes the segment count to overflow. This can be avoided by taking the viewport size and culling into account during estimation since a majority of the shape lies outside the viewport. See #541.
Rendering Issues