add emoji family for emoji clusters #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick and dirty fallback for emoji. This can be done more efficiently (and should be handled in fontique directly) but this should get us functioning emoji mapping for capable renderers.
DJMcNab
previously approved these changes
May 22, 2024
There was a problem hiding this comment.
Is it meaningful to have a test for this?
cc @nicoburns for turning #55 and/or #54 also into integration tests
nicoburns
reviewed
May 22, 2024
nicoburns
reviewed
May 22, 2024
|
Applying this on top of the tiny-skia example I get a blank space for the emoji (which is expected because the 
On top of the swash example I get "interesting" output: 
I'm assuming this is an issue with the example rather than this PR as it seems to selecting the correct font/glyph. |
Forces a reset after we push a specialized font stack for an emoji cluster
nicoburns
approved these changes
May 22, 2024
It is meaningful but the structure of this file makes unit testing difficult. I filed an issue for refactoring at #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick and dirty fallback for emoji. This can be done more efficiently (and should be handled in fontique directly) but this should get us functioning emoji mapping for capable renderers.