This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
deps: Update keyboard-types to 0.7.
#158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us remove our `ModifiersExt` now that that functionality is available in the upstream release.
|
We should also update to use pyfisch/keyboard-types#34, I think |
xStrom
approved these changes
Aug 20, 2023
|
@DJMcNab Windows and macOS don't seem to have that many F keys, but X11 does. I've identified some issues with the Windows code and have a lot of questions about the macOS code, but would rather handle them in separate follow up PRs as they aren't really related to this change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us remove our
ModifiersExtnow that that functionality is available in the upstream release.