Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow symfony 7 #286

Merged
merged 6 commits into from
Nov 24, 2023
Merged

Conversation

@Chris53897
Copy link
Contributor Author

Last Update from enlightn/security-checker is from February 2022.
Maybe we can remove that in the ci for symfony 7 run, until that is merged.

@kbond
Copy link
Collaborator

kbond commented Nov 16, 2023

Maybe we can remove that in the ci for symfony 7 run, until that is merged.

Ak, we can't as it's a hard dependency of laminas/laminas-diagnostics

@Chris53897
Copy link
Contributor Author

Ok. I did ping the maintainer now.

@kbond
Copy link
Collaborator

kbond commented Nov 16, 2023

See laminas/laminas-diagnostics#73

@Chris53897
Copy link
Contributor Author

Looks good now (after PHP-CS-Fixer added support for Symfony 7).
Stability should be changed after the first stable release of symfony 7.

And i think this PR #283 should be merged first. to ensure PHP 8.3 test.

composer.json Outdated Show resolved Hide resolved
@kbond
Copy link
Collaborator

kbond commented Nov 23, 2023

to ensure PHP 8.3 test.

Unfortunately, laminas-diagnostics doesn't support 8.3 yet.

@Chris53897
Copy link
Contributor Author

Chris53897 commented Nov 24, 2023

Ok i see. Lets wait for this PR to be merged.
laminas/laminas-diagnostics#74

Update: merged, but not yet released.

@kbond
Copy link
Collaborator

kbond commented Nov 24, 2023

Is this one ready to merge or do you still want to wait for #283?

@Chris53897
Copy link
Contributor Author

Is it ready to merge

@kbond
Copy link
Collaborator

kbond commented Nov 24, 2023

Thanks @Chris53897!

@kbond kbond merged commit 8339ae6 into liip:master Nov 24, 2023
17 checks passed
@Chris53897 Chris53897 deleted the feature/allow-symfony-7 branch November 27, 2023 08:23
@alessandro-podo
Copy link

Is there any planning for when a new release will be released with this feature?

@kbond
Copy link
Collaborator

kbond commented Jan 2, 2024

Thanks for the ping @alessandro-podo, I just released 2.22.0 which includes Symfony 7 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants