Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of GaussianMixtureMasksTransform #1692

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

snehilchatterjee
Copy link
Contributor

Modified Components:

  • lightly/transforms/__init__.py

New Files:

  • lightly/transforms/gaussian_mixture_masks_transform.py
  • tests/transforms/test_gaussian_mixture_masks.py

Enhancement:

  • Added support for Gaussian Mixture Mask transform

Fixes Issue:

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.85%. Comparing base (b8613dc) to head (b68b473).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1692      +/-   ##
==========================================
+ Coverage   84.78%   84.85%   +0.07%     
==========================================
  Files         154      155       +1     
  Lines        6479     6509      +30     
==========================================
+ Hits         5493     5523      +30     
  Misses        986      986              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SauravMaheshkar
Copy link
Collaborator

@snehilchatterjee, could you provide some input-output pairs?

@snehilchatterjee
Copy link
Contributor Author

image

@guarin guarin self-requested a review October 14, 2024 06:48
Copy link
Contributor

@guarin guarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR, the augmentations look great! I left some comments to make the interface identical to the other FFT transforms.

lightly/transforms/gaussian_mixture_masks_transform.py Outdated Show resolved Hide resolved
lightly/transforms/gaussian_mixture_masks_transform.py Outdated Show resolved Hide resolved
lightly/transforms/gaussian_mixture_masks_transform.py Outdated Show resolved Hide resolved
lightly/transforms/gaussian_mixture_masks_transform.py Outdated Show resolved Hide resolved
lightly/transforms/gaussian_mixture_masks_transform.py Outdated Show resolved Hide resolved
lightly/transforms/gaussian_mixture_masks_transform.py Outdated Show resolved Hide resolved
lightly/transforms/gaussian_mixture_masks_transform.py Outdated Show resolved Hide resolved
lightly/transforms/gaussian_mixture_masks_transform.py Outdated Show resolved Hide resolved
Copy link
Contributor

@guarin guarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Reviewed again

lightly/transforms/gaussian_mixture_masks_transform.py Outdated Show resolved Hide resolved
lightly/transforms/gaussian_mixture_masks_transform.py Outdated Show resolved Hide resolved
lightly/transforms/gaussian_mixture_masks_transform.py Outdated Show resolved Hide resolved
tests/transforms/test_gaussian_mixture_masks.py Outdated Show resolved Hide resolved
lightly/transforms/gaussian_mixture_masks_transform.py Outdated Show resolved Hide resolved
@snehilchatterjee
Copy link
Contributor Author

After making the changes this is the output:

image

Copy link
Contributor

@guarin guarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks so much!

@guarin guarin merged commit fe7664a into lightly-ai:master Oct 16, 2024
14 checks passed
@snehilchatterjee
Copy link
Contributor Author

Glad I could contribute

payo101 pushed a commit to payo101/lightly that referenced this pull request Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GaussianMixtureMask transform
3 participants