Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regenerate specs: allow the index to be set when creating a sample #1688

Closed
wants to merge 4 commits into from

Conversation

japrescott
Copy link
Contributor

part of lig-5509

  • regenerate specs: allow the index to be set when creating a sample

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.78%. Comparing base (56e669a) to head (065ece4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1688   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files         154      154           
  Lines        6479     6479           
=======================================
  Hits         5493     5493           
  Misses        986      986           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@guarin guarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@japrescott japrescott closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants