-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory bank distributed training support #1293
Memory bank distributed training support #1293
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## guarin-lig-3062-add-mocov2-imagenet-benchmark #1293 +/- ##
=================================================================================
+ Coverage 85.22% 85.27% +0.04%
=================================================================================
Files 130 130
Lines 5522 5533 +11
=================================================================================
+ Hits 4706 4718 +12
+ Misses 816 815 -1 ☔ View full report in Codecov by Sentry. |
…rin-memory-bank-ddp-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, let's see how the MoCo benchmarks works now.
…rin-memory-bank-ddp-support
Merging this as the model is training well, see #1291 |
641ecf2
into
guarin-lig-3062-add-mocov2-imagenet-benchmark
Changes
feature_dim_first
argument to memory bank. This is required for backwards compatibility. In the future we should be able to setfeature_dim_first=False
and remove the requirement for transposing features coming from the feature bank.size=num_features
tosize=(num_features, dim)
.How was it tested?