Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: develop from core repo #854

Merged
merged 1,110 commits into from
Oct 11, 2024
Merged

sync: develop from core repo #854

merged 1,110 commits into from
Oct 11, 2024

Conversation

tamtamchik
Copy link
Member

No description provided.

tamtamchik and others added 24 commits October 7, 2024 13:18
feat: add Simple DVT to scratch deploy
docs(readme): add repovation disclaimer
backport: changes from master to develop
# Conflicts:
#	.github/workflows/analyse.yml
#	.github/workflows/assert-bytecode.yml
#	.github/workflows/fix-abi-pr.yml
#	.github/workflows/linters.yml
#	.github/workflows/release-abis.yml
#	.github/workflows/storage-layout-check.yml
#	.github/workflows/storage-layout-update.yml
#	.gitignore
#	README.md
#	accounts.sample.json
#	apps/lido/scripts/buidler-hooks.js
#	apps/lidooracle/scripts/buidler-hooks.js
#	apps/node-operators-registry/scripts/buidler-hooks.js
#	contracts/common/test_helpers/SignatureUtilsConsumer_0_4_24.sol
#	contracts/common/test_helpers/SignatureUtilsConsumer_0_8_9.sol
#	deployed-goerli.json
#	deployed-mainnet.json
#	deployed-sepolia.json
#	docs/scratch-deploy.md
#	gasprofile/gasprofile.js
#	hardhat.config.js
#	package.json
#	poetry.lock
#	pyproject.toml
#	scripts/constants.js
#	scripts/extract-artifacts.js
#	scripts/hardhat-tasks.js
#	scripts/helpers/assert.js
#	scripts/helpers/deploy.js
#	scripts/helpers/persisted-network-state.js
#	scripts/helpers/run-or-wrap-script.js
#	scripts/scratch/01-deploy-deposit-contract.js
#	scripts/scratch/05-obtain-deployed-instances.js
#	scripts/scratch/06-register-ens-domain.js
#	scripts/scratch/07-deploy-apm.js
#	scripts/scratch/08-obtain-deployed-apm.js
#	scripts/scratch/10-deploy-dao.js
#	scripts/scratch/12-issue-tokens.js
#	scripts/scratch/13-deploy-non-aragon-contracts.js
#	scripts/scratch/15-finalize-dao.js
#	scripts/scratch/16-initialize-non-aragon-contracts.js
#	scripts/scratch/20-check-dao.js
#	scripts/scratch/checks/apps.js
#	scripts/staking-router.js
#	scripts/upgrade/deploy-new-app-instance.js
#	scripts/upgrade/obtain-deployed-new-app-instance.js
#	scripts/upgrade/upgrade-app.js
#	scripts/upgrade/vote-new-oracle-impl.js
#	scripts/utils/verify-vote-tx.js
#	test/0.8.9/withdrawal-queue-share-rate-changes.test.js
#	test/common/math-256.test.sol
#	test/common/signature-utils.test.sol
#	test/helpers/config.js
#	test/helpers/factories.js
#	test/helpers/oracle.js
#	test/helpers/protocol.js
#	test/helpers/utils.js
#	test/scenario/lido-wq-acct-oracle-integration-gas.test.js
#	yarn.lock
# Conflicts:
#	README.md
#	deployed-mainnet.json
#	lib/deploy.ts
#	package.json
#	test/0.8.9/contracts/AccountingOracle__MockForSanityChecker.sol
contracts/0.8.9/lib/SafeCastExt.sol Dismissed Show dismissed Hide dismissed
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol Dismissed Show dismissed Hide dismissed
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol Dismissed Show dismissed Hide dismissed
Copy link

badge

Hardhat Unit Tests Coverage Summary

Filename                                                       Stmts    Miss  Cover    Missing
-----------------------------------------------------------  -------  ------  -------  ---------
contracts/0.4.24/Lido.sol                                        212       0  100.00%
contracts/0.4.24/StETH.sol                                        72       0  100.00%
contracts/0.4.24/StETHPermit.sol                                  15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                5       0  100.00%
contracts/0.4.24/lib/SigningKeys.sol                              36       0  100.00%
contracts/0.4.24/lib/StakeLimitUtils.sol                          37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   485       0  100.00%
contracts/0.4.24/oracle/LegacyOracle.sol                          72       0  100.00%
contracts/0.4.24/utils/Pausable.sol                                9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                               5       0  100.00%
contracts/0.6.12/WstETH.sol                                       17       0  100.00%
contracts/0.8.4/WithdrawalsManagerProxy.sol                       61       0  100.00%
contracts/0.8.9/BeaconChainDepositor.sol                          21       2  90.48%   48, 51
contracts/0.8.9/Burner.sol                                        71       0  100.00%
contracts/0.8.9/DepositSecurityModule.sol                        104       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                   16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                16       0  100.00%
contracts/0.8.9/LidoLocator.sol                                   18       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                            28       0  100.00%
contracts/0.8.9/StakingRouter.sol                                303       0  100.00%
contracts/0.8.9/WithdrawalQueue.sol                               88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                          146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                         89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                               21       0  100.00%
contracts/0.8.9/lib/Math.sol                                       4       0  100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                22       0  100.00%
contracts/0.8.9/lib/SafeCastExt.sol                                3       1  66.67%   26
contracts/0.8.9/lib/UnstructuredRefStorage.sol                     2       0  100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                      171       1  99.42%   723
contracts/0.8.9/oracle/BaseOracle.sol                             89       1  98.88%   397
contracts/0.8.9/oracle/HashConsensus.sol                         263       1  99.62%   1005
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                91      91  0.00%    96-461
contracts/0.8.9/proxy/OssifiableProxy.sol                         17       0  100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      225       0  100.00%
contracts/0.8.9/utils/DummyEmptyContract.sol                       0       0  100.00%
contracts/0.8.9/utils/PausableUntil.sol                           31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                               11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                    23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol           9       0  100.00%
contracts/testnets/sepolia/SepoliaDepositAdapter.sol              21      21  0.00%    49-100
TOTAL                                                           2929     118  95.97%

Results for commit: 71badc1

Minimum allowed coverage is 95%

♻️ This comment has been updated with latest results

Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit 👀

Compared against master and found only Negative Rebase protection changes

@TheDZhon TheDZhon merged commit c2470f5 into develop Oct 11, 2024
10 checks passed
@TheDZhon TheDZhon deleted the sync/develop branch October 11, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants