Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unwrap and wq stats #513

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: unwrap and wq stats #513

wants to merge 3 commits into from

Conversation

solidovic
Copy link
Contributor

Description

  • fix(unwrap stats): hide allowance (if he is not needed)
  • fix(wq stats): hide stats for l2

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@solidovic solidovic requested review from a team as code owners October 17, 2024 10:54
@solidovic solidovic changed the title Fix/stats fix: unwrap and wq stats Oct 17, 2024
@preview-stands
Copy link

preview-stands bot commented Oct 17, 2024 •
edited
Loading

Preview stand status

Preview stand available on testnet

DiRaiks
DiRaiks requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@DiRaiks DiRaiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest changing the approach to writing code. The current number of flags and completely different approaches to their use leads to a lack of understanding of what is happening in the code and why. In the future this will become a magic box with a support problem. I cannot agree to merge in the form that it is now

@Jeday
Copy link
Contributor

Jeday commented Oct 17, 2024

@DiRaiks completely agree, I addressed those issues in #510. We might be able to incorporate #513 in #510 to fix situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeday Jeday Jeday approved these changes

@DiRaiks DiRaiks Awaiting requested review from DiRaiks

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@solidovic @Jeday @DiRaiks