L2 bots unification #558
Draft
L2 bots unification #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arwer13
changed the title
sergeyWh1te
requested changes
Jun 10, 2024
| const PROD = "prod"; | ||
|
|
||
|
|
||
| function parseCommandLineArgs() { |
There was a problem hiding this comment.
we don't use it at all.
Just remove it
| return { l2NetworkName, runMode }; | ||
| } | ||
|
|
||
| const main = async () => { |
There was a problem hiding this comment.
I'd prefer to call file just main.ts
There was a problem hiding this comment.
- need to add read .env capability
- we need to opent http server for grabbing prom metrics
|
|
||
| const version = { | ||
| desc: `${commitHashShort}${commitHashSuffux} (${commitMsgShort})`, |
There was a problem hiding this comment.
In local infra we don't need it anymore
|
|
||
| FROM base as builder | ||
|
|
||
| ARG L2_NETWORK_NAME |
There was a problem hiding this comment.
Pass env though linux .env
| @@ -0,0 +1,34 @@ | |||
| [ | |||
There was a problem hiding this comment.
speaking about abi.
Move it please into root 'brief' folder like in steth. Because we have to have smt some and also we have to add here grpc capabilities.
l2-bridges/common/utils/constants.ts
Outdated
|
|
||
| export const ETH_DECIMALS = new BigNumber(10).pow(18) | ||
| export const MAINNET_CHAIN_ID = 1 | ||
| export const DRPC_URL = 'https://eth.drpc.org/' |
There was a problem hiding this comment.
must be read from .env variables
It is not needed because proxies admin and implementation changes are monitored by watching events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gathering l2 bots under the same directory eliminating excessive code duplication.