Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add casts to ARM NEON code #409

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Oct 15, 2024

The code was switching between uint8x16_t <-> uint16x8_t <-> uint32x4_t, without casts

Fixes #405

Copy link
Collaborator

@slouken slouken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me... @1bsyl?

@1bsyl
Copy link
Contributor

1bsyl commented Oct 15, 2024

I've forgotten almost everything on neon assembly :) but if that still compiles on latest ndk and runs without glitches, that's probably ok.

I can give a try once you commit it !

@slouken slouken merged commit b61b50e into libsdl-org:main Oct 15, 2024
5 checks passed
@1bsyl
Copy link
Contributor

1bsyl commented Oct 15, 2024

@madebr @slouken , I've tried and this seems ok to me!

@slouken
Copy link
Collaborator

slouken commented Oct 15, 2024

Great, thanks!

@sezero
Copy link
Contributor

sezero commented Oct 15, 2024

Is SDL2 branch OK?

@slouken
Copy link
Collaborator

slouken commented Oct 15, 2024

Yep, @madebr or @sezero, if you can cherry-pick to main that would be great.

@madebr madebr deleted the fix-arm-neon-types branch October 15, 2024 21:39
@madebr
Copy link
Contributor Author

madebr commented Oct 15, 2024

I cherry-picked this commit in a3d0895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors when building from source on aarch64 Linux
4 participants