Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: set additional env configuration #401

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

crazy-max
Copy link
Member

No description provided.

@murrant
Copy link
Member

murrant commented Sep 30, 2023

Should probably have a note that these variables need to be set to the same value across the cluster (much like NODE_ID needs to be unique)

@crazy-max
Copy link
Member Author

Should probably have a note that these variables need to be set to the same value across the cluster (much like NODE_ID needs to be unique)

We don't have any support for kubernetes or swarm yet with the current implementation but if you mean that /data/.env should be used in the main container and sidecar ones as well, this is already the case as we mount the same volume across the compose stack:

volumes:
- "./librenms:/data"

volumes:
- "./librenms:/data"

volumes:
- "./librenms:/data"

...

@murrant
Copy link
Member

murrant commented Oct 1, 2023

If .env is shared across containers, how can NODE_ID be unique if it is set there?

@crazy-max
Copy link
Member Author

If .env is shared across containers, how can NODE_ID be unique if it is set there?

Oh I guess you mean for the dispatcher container? In this case I think we should provide a NODE_ID env var that would override the one from /data/.env. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants