feat: remove Control and ControlledConnection
#164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is covered by `prop_send_recv_multi`.
thomaseizinger
changed the title
Control and ControlledConnection
mxinden
approved these changes
Jul 3, 2023
Comment on lines
+108
to
+118
| pub struct MessageSender<T> { | ||
| connection: Connection<T>, | ||
| pending_messages: Vec<Msg>, | ||
| worker_streams: FuturesUnordered<BoxFuture<'static, ()>>, | ||
| streams_processed: usize, | ||
| /// Whether to spawn a new task for each stream. | ||
| spawn_tasks: bool, | ||
| /// How many times to send each message on the stream | ||
| message_multiplier: u64, | ||
| strategy: MessageSenderStrategy, | ||
| } |
Co-authored-by: Max Inden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To remove
Control, we need to migrate all tests and benchmarks to use the new poll-based API. This is done at a best-effort basis.There is likely a cleaner design for the tests but I wanted to minimize the amount of work we put into this library. What I wanted to get to is having #153 merged and implement #154.
Especially the benchmarks are somewhat dated I think we are better off using the new cross-implementation benchmarking infrastructure to check the performance of
rust-yamux.Resolves #157.