Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use if-watch-plus instead of if-watch #5624

Conversation

RawinSader
Copy link

@RawinSader RawinSader commented Oct 5, 2024

Description

Libp2p relies on a package called [email protected] in 4 different places:

  • transport/tcp
  • transport/quic
  • transport/webrtc
  • protocol/mdns

This unmaintained library uses a deprecate iOS interface through one of its own dependencies `[email protected]:

Seeing that our bindings use this deprecated interface, iOS apps will fail to build for everyone using rust-libp2p.

Notes & open questions

  • This PR uses a forked version of if-watch that only updates the system-configurations dependency to the latest version that addresses the deprecated interface
  • This PR does not cover tests that should fall under system-configurations

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@dariusc93 dariusc93 changed the title Uniffi swift undefined symbols _kSCNetworkInterfaceTypeIrDA fix chore: use if-watch-next instead of if-watch Oct 6, 2024
@dariusc93 dariusc93 changed the title chore: use if-watch-next instead of if-watch chore: use if-watch-plus instead of if-watch Oct 6, 2024
@dariusc93
Copy link
Member

Thanks for the PR! Can you update the workspace Cargo.toml as well? :)

Rawi Sader added 2 commits October 8, 2024 12:45
…m:RawinSader/rust-libp2p into rawi/ios-cross-compilation-dependency-fix
@RawinSader
Copy link
Author

Thanks for the PR! Can you update the workspace Cargo.toml as well? :)

Update me if there is anything else I forgot to do :)

@jxs
Copy link
Member

jxs commented Oct 11, 2024

Hi, in the rust-libp2p community call I remarked that it was strange that if-watch was unmaintained, but I have since found libp2p/if-watch#37 (comment), I have also acted upon it and wrote libp2p/if-watch#37 (comment). So I suggest we wait to move the repo and I can then accept a PR there and release a new version.

Copy link
Contributor

mergify bot commented Oct 15, 2024

This pull request has merge conflicts. Could you please resolve them @RawinSader? 🙏

@dariusc93
Copy link
Member

Since if-watch was moved to llibp2p org, this issue could be closed now no?

CC @jxs

@RawinSader
Copy link
Author

If we do close this would you want me to submit another PR to the new repo?

@dariusc93
Copy link
Member

If we do close this would you want me to submit another PR to the new repo?

Yes please :)

@dariusc93
Copy link
Member

Closing due to if-watch repo ownership changed to libp2p org.

@dariusc93 dariusc93 closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants