Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: Improve error message by including specific reasons #39

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

ackintosh
Copy link
Contributor

This PR improves the rtnetlink socket closed error message by including specific reasons for the error. This enhancement helps users understand why the error occurs in certain situations.

@ackintosh
Copy link
Contributor Author

The armv7-linux-androideabi and aarch64-linux-android builds were failing previously, which I believe is unrelated to this PR.

@ackintosh
Copy link
Contributor Author

ackintosh commented Apr 16, 2024

#40 will fix the Android CI error.

@ackintosh
Copy link
Contributor Author

@mxinden Any feedback?

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akihito!

@jxs jxs merged commit 8ac0816 into libp2p:master Nov 12, 2024
7 checks passed
@ackintosh ackintosh deleted the rtnetlink-socket-error-message branch November 12, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants