Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "transient" network connectivity state #2696

Merged
merged 18 commits into from
May 8, 2024

Commits on May 5, 2024

  1. Add a "transient" network connectivity state

    Previously, we'd consider "transiently" connected peers to be connected.
    This meant:
    
    1. We wouldn't fire a second event when transitioning to "really
    connected". The only option for users was to listen on the old-style
    per-connection notifications.
    2. "Connectedness" checks would be a little too eager to treat a peer as
    connected.
    
    For 99% of users, "transient" peers should be treated as disconnected.
    So while it's technically a breaking change to split-out "transient"
    connectivity into a separate state, I expect it's more likely to fix
    bugs than anything.
    
    Unfortunately, this change _did_ require several changes to go-libp2p
    itself because go-libp2p _does_ care about transient connections:
    
    1. We want to keep peerstore information for transient peers.
    2. We may sometimes want to treat peers as "connected" in the host.
    3. Identify still needs to run over transient connections.
    
    fixes #2692
    Stebalien authored and sukunrt committed May 5, 2024
    Configuration menu
    Copy the full SHA
    374ec48 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    14024ef View commit details
    Browse the repository at this point in the history
  3. updated removeConn

    guillaumemichel authored and sukunrt committed May 5, 2024
    Configuration menu
    Copy the full SHA
    e3215d9 View commit details
    Browse the repository at this point in the history
  4. corrected removeConn

    guillaumemichel authored and sukunrt committed May 5, 2024
    Configuration menu
    Copy the full SHA
    5ee3942 View commit details
    Browse the repository at this point in the history
  5. restored comment

    guillaumemichel authored and sukunrt committed May 5, 2024
    Configuration menu
    Copy the full SHA
    bed69dc View commit details
    Browse the repository at this point in the history
  6. updated connectednessUnlocked

    guillaumemichel authored and sukunrt committed May 5, 2024
    Configuration menu
    Copy the full SHA
    678d8b4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9b9556a View commit details
    Browse the repository at this point in the history
  8. More renaming

    MarcoPolo authored and sukunrt committed May 5, 2024
    Configuration menu
    Copy the full SHA
    84bc0b1 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    98191a4 View commit details
    Browse the repository at this point in the history
  10. improve connectedness check

    sukunrt committed May 5, 2024
    Configuration menu
    Copy the full SHA
    d52e900 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    eb65e0f View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    89a8442 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    ac195c5 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    d8e7c31 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    02b210d View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    4573ce6 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    25ccbf2 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. review comments

    sukunrt committed May 7, 2024
    Configuration menu
    Copy the full SHA
    b542b15 View commit details
    Browse the repository at this point in the history