-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "transient" network connectivity state #2696
Merged
Merged
Commits on May 5, 2024
-
Add a "transient" network connectivity state
Previously, we'd consider "transiently" connected peers to be connected. This meant: 1. We wouldn't fire a second event when transitioning to "really connected". The only option for users was to listen on the old-style per-connection notifications. 2. "Connectedness" checks would be a little too eager to treat a peer as connected. For 99% of users, "transient" peers should be treated as disconnected. So while it's technically a breaking change to split-out "transient" connectivity into a separate state, I expect it's more likely to fix bugs than anything. Unfortunately, this change _did_ require several changes to go-libp2p itself because go-libp2p _does_ care about transient connections: 1. We want to keep peerstore information for transient peers. 2. We may sometimes want to treat peers as "connected" in the host. 3. Identify still needs to run over transient connections. fixes #2692
Configuration menu - View commit details
-
Copy full SHA for 374ec48 - Browse repository at this point
Copy the full SHA 374ec48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14024ef - Browse repository at this point
Copy the full SHA 14024efView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3215d9 - Browse repository at this point
Copy the full SHA e3215d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ee3942 - Browse repository at this point
Copy the full SHA 5ee3942View commit details -
Configuration menu - View commit details
-
Copy full SHA for bed69dc - Browse repository at this point
Copy the full SHA bed69dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 678d8b4 - Browse repository at this point
Copy the full SHA 678d8b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b9556a - Browse repository at this point
Copy the full SHA 9b9556aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 84bc0b1 - Browse repository at this point
Copy the full SHA 84bc0b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98191a4 - Browse repository at this point
Copy the full SHA 98191a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d52e900 - Browse repository at this point
Copy the full SHA d52e900View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb65e0f - Browse repository at this point
Copy the full SHA eb65e0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 89a8442 - Browse repository at this point
Copy the full SHA 89a8442View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac195c5 - Browse repository at this point
Copy the full SHA ac195c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8e7c31 - Browse repository at this point
Copy the full SHA d8e7c31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02b210d - Browse repository at this point
Copy the full SHA 02b210dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4573ce6 - Browse repository at this point
Copy the full SHA 4573ce6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25ccbf2 - Browse repository at this point
Copy the full SHA 25ccbf2View commit details
Commits on May 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b542b15 - Browse repository at this point
Copy the full SHA b542b15View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.