Remove gogo protobuf #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumemichel
force-pushed
the
fix/deprecate-gogo
branch
2 times, most recently
from
ca3fb23
to
8bc0539
Compare
vyzo
reviewed
Aug 7, 2024
There was a problem hiding this comment.
you need to consider downstream consumers who are probably still using gogo with the generated code, which are likely to break.
So if you want to kill gogo, you have to do it in the consumers as well, and this quickly becomes quite a large project in itself.
Note: I am not suggesting that we should keep gogo, by all means it is deprecated and we should move away from it, just pointing out that it is not trivial.
guillaumemichel
force-pushed
the
fix/deprecate-gogo
branch
from
8bc0539
to
26aae8f
Compare
|
Yes, I am moving go-libp2p-kad-dht away from gogo, and there is a dependency on go-libp2p-record. The plan is to make a new release of go-libp2p-record so that consumers can move away from gogo when they are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gogo protobuf is deprecated. Move away from it.
Also updated dependencies.