Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename rust-libp2p maintainers #258

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

jxs
Copy link
Member

@jxs jxs commented Oct 30, 2024

Summary

#252 seems to have broken the link between the name of the group on this config file and the actual ACL on crates.io, this PR attempts to fix that

@jxs jxs requested review from a team as code owners October 30, 2024 12:06
Copy link
Contributor

The following access changes will be introduced as a result of applying the plan:

Access Changes
There will be no access changes

Copy link
Contributor

@guillaumemichel guillaumemichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jxs!

Copy link
Contributor

github-actions bot commented Oct 30, 2024

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # github_team.this["rust-libp2p maintainers"] will be created
  + resource "github_team" "this" {
      + create_default_maintainer = false
      + description               = "Current maintainers of Rust-libp2p"
      + etag                      = (known after apply)
      + id                        = (known after apply)
      + members_count             = (known after apply)
      + name                      = "rust-libp2p Maintainers"
      + node_id                   = (known after apply)
      + privacy                   = "closed"
      + slug                      = (known after apply)
    }

  # github_team.this["rust-libp2p-maintainers"] will be destroyed
  # (because key ["rust-libp2p-maintainers"] is not in for_each map)
  - resource "github_team" "this" {
      - create_default_maintainer = false -> null
      - description               = "Current maintainers of Rust-libp2p" -> null
      - etag                      = "W/\"bf10a242408642a8c8edf0f399c65801d758f612dc661983adbf25484aef394b\"" -> null
      - id                        = "11227601" -> null
      - members_count             = 3 -> null
      - name                      = "rust-libp2p-maintainers" -> null
      - node_id                   = "T_kwDOAOJp3s4Aq1HR" -> null
      - privacy                   = "closed" -> null
      - slug                      = "rust-libp2p-maintainers" -> null
    }

  # github_team_membership.this["rust-libp2p maintainers:agemanning"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "maintainer"
      + team_id  = (known after apply)
      + username = "AgeManning"
    }

  # github_team_membership.this["rust-libp2p maintainers:guillaumemichel"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "maintainer"
      + team_id  = (known after apply)
      + username = "guillaumemichel"
    }

  # github_team_membership.this["rust-libp2p maintainers:jxs"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "maintainer"
      + team_id  = (known after apply)
      + username = "jxs"
    }

  # github_team_membership.this["rust-libp2p-maintainers:agemanning"] will be destroyed
  # (because key ["rust-libp2p-maintainers:agemanning"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"b523b6bf4c8a3bd94058ca29923045845a0192ed7dd1d5e74bb454dc68c8af98\"" -> null
      - id       = "11227601:AgeManning" -> null
      - role     = "maintainer" -> null
      - team_id  = "11227601" -> null
      - username = "AgeManning" -> null
    }

  # github_team_membership.this["rust-libp2p-maintainers:guillaumemichel"] will be destroyed
  # (because key ["rust-libp2p-maintainers:guillaumemichel"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"a77e871fe4d9ef9a1c33a64f3c5443fcf6e5ed162d7823c83e335d5b237c2ed8\"" -> null
      - id       = "11227601:guillaumemichel" -> null
      - role     = "maintainer" -> null
      - team_id  = "11227601" -> null
      - username = "guillaumemichel" -> null
    }

  # github_team_membership.this["rust-libp2p-maintainers:jxs"] will be destroyed
  # (because key ["rust-libp2p-maintainers:jxs"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"3393d42f15cb267d41a7fa6670d90bceef37c7baaff9c35a9d436b881e5a47d6\"" -> null
      - id       = "11227601:jxs" -> null
      - role     = "maintainer" -> null
      - team_id  = "11227601" -> null
      - username = "jxs" -> null
    }

  # github_team_repository.this["rust-libp2p maintainers:blog"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "blog"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p maintainers:demo-multi-lang"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "demo-multi-lang"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p maintainers:developer-meetings"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "admin"
      + repository = "developer-meetings"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p maintainers:docs"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "docs"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p maintainers:notes"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "notes"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p maintainers:projects"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "projects"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p maintainers:rust-libp2p"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "admin"
      + repository = "rust-libp2p"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p maintainers:rust-libp2p-identity"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "admin"
      + repository = "rust-libp2p-identity"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p maintainers:rust-yamux"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "admin"
      + repository = "rust-yamux"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p maintainers:team-mgmt"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "team-mgmt"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p maintainers:test-plans"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "test-plans"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p maintainers:universal-connectivity"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "maintain"
      + repository = "universal-connectivity"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["rust-libp2p-maintainers:blog"] will be destroyed
  # (because key ["rust-libp2p-maintainers:blog"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"e2933a3f24625750f995c813672d4ce48307a6e453c395b4c1bf54e33c9e0edd\"" -> null
      - id         = "11227601:blog" -> null
      - permission = "push" -> null
      - repository = "blog" -> null
      - team_id    = "11227601" -> null
    }

  # github_team_repository.this["rust-libp2p-maintainers:demo-multi-lang"] will be destroyed
  # (because key ["rust-libp2p-maintainers:demo-multi-lang"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"7d877458f5608423b7abd14ec2cc54760dd7fc117ea39077908a42cc3e3535ae\"" -> null
      - id         = "11227601:demo-multi-lang" -> null
      - permission = "push" -> null
      - repository = "demo-multi-lang" -> null
      - team_id    = "11227601" -> null
    }

  # github_team_repository.this["rust-libp2p-maintainers:developer-meetings"] will be destroyed
  # (because key ["rust-libp2p-maintainers:developer-meetings"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"feb398c3b5a69ba3000a90b41903e0959d27b593634285516265394f054c2e01\"" -> null
      - id         = "11227601:developer-meetings" -> null
      - permission = "admin" -> null
      - repository = "developer-meetings" -> null
      - team_id    = "11227601" -> null
    }

  # github_team_repository.this["rust-libp2p-maintainers:docs"] will be destroyed
  # (because key ["rust-libp2p-maintainers:docs"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"267f17cc4b1f324808ba5ac5d9936313a579f0b5496ea1972ad7d72f2a27e82a\"" -> null
      - id         = "11227601:docs" -> null
      - permission = "push" -> null
      - repository = "docs" -> null
      - team_id    = "11227601" -> null
    }

  # github_team_repository.this["rust-libp2p-maintainers:notes"] will be destroyed
  # (because key ["rust-libp2p-maintainers:notes"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"29bd08a633fd94567742a3322100d498cfade58ccf48ce33932774c3840272de\"" -> null
      - id         = "11227601:notes" -> null
      - permission = "push" -> null
      - repository = "notes" -> null
      - team_id    = "11227601" -> null
    }

  # github_team_repository.this["rust-libp2p-maintainers:projects"] will be destroyed
  # (because key ["rust-libp2p-maintainers:projects"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"a0ac45e14422d5c136b041035dc7bf2f956a2f54af81de0b8c989534c75ad506\"" -> null
      - id         = "11227601:projects" -> null
      - permission = "push" -> null
      - repository = "projects" -> null
      - team_id    = "11227601" -> null
    }

  # github_team_repository.this["rust-libp2p-maintainers:rust-libp2p"] will be destroyed
  # (because key ["rust-libp2p-maintainers:rust-libp2p"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"c30f2865a149f81780610bdae66a19bffea1668584709fa0bbed0968d406bd67\"" -> null
      - id         = "11227601:rust-libp2p" -> null
      - permission = "admin" -> null
      - repository = "rust-libp2p" -> null
      - team_id    = "11227601" -> null
    }

  # github_team_repository.this["rust-libp2p-maintainers:rust-libp2p-identity"] will be destroyed
  # (because key ["rust-libp2p-maintainers:rust-libp2p-identity"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"b4daeeb67b18cac54aef8dfe41afa61bad6331ede6817a269c82500b59852790\"" -> null
      - id         = "11227601:rust-libp2p-identity" -> null
      - permission = "admin" -> null
      - repository = "rust-libp2p-identity" -> null
      - team_id    = "11227601" -> null
    }

  # github_team_repository.this["rust-libp2p-maintainers:rust-yamux"] will be destroyed
  # (because key ["rust-libp2p-maintainers:rust-yamux"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"1e7f0a070b207b31a5d58008fdf813de370e0b0080e1a263dbb4956958e0629d\"" -> null
      - id         = "11227601:rust-yamux" -> null
      - permission = "admin" -> null
      - repository = "rust-yamux" -> null
      - team_id    = "11227601" -> null
    }

  # github_team_repository.this["rust-libp2p-maintainers:team-mgmt"] will be destroyed
  # (because key ["rust-libp2p-maintainers:team-mgmt"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"370cd87c530ec71b9017f2f37e1a3ded968954465209dcf57119e36f84458c3c\"" -> null
      - id         = "11227601:team-mgmt" -> null
      - permission = "push" -> null
      - repository = "team-mgmt" -> null
      - team_id    = "11227601" -> null
    }

  # github_team_repository.this["rust-libp2p-maintainers:test-plans"] will be destroyed
  # (because key ["rust-libp2p-maintainers:test-plans"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"579b2e39843466d75936b5b8b73bad8a5fd309c0999570522634211f0d0a6e41\"" -> null
      - id         = "11227601:test-plans" -> null
      - permission = "push" -> null
      - repository = "test-plans" -> null
      - team_id    = "11227601" -> null
    }

  # github_team_repository.this["rust-libp2p-maintainers:universal-connectivity"] will be destroyed
  # (because key ["rust-libp2p-maintainers:universal-connectivity"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"e2d44baef9ff10c1e1737380f2658bbb25ea89eefb81ccb4ee31ef90bd835571\"" -> null
      - id         = "11227601:universal-connectivity" -> null
      - permission = "maintain" -> null
      - repository = "universal-connectivity" -> null
      - team_id    = "11227601" -> null
    }

Plan: 16 to add, 0 to change, 16 to destroy.

@jxs jxs merged commit 97b7529 into libp2p:master Oct 30, 2024
6 checks passed
@jxs
Copy link
Member Author

jxs commented Oct 30, 2024

thanks Prithvi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants