Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SgtPooki can manage issue labels in js-libp2p-examples #250

Merged
merged 8 commits into from
Sep 30, 2024

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Sep 22, 2024

Summary

Grant SgtPooki admin access to js-libp2p-examples

Why do you need this?

So I can add/adjust labels in the example repo: https://github.com/libp2p/js-libp2p-examples

What else do we need to know?

I don't need full Admin, but triage rights would allow me to help monitor/maintain repos I can help with

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@SgtPooki SgtPooki requested review from a team as code owners September 22, 2024 11:07
Copy link
Contributor

github-actions bot commented Sep 22, 2024

The following access changes will be introduced as a result of applying the plan:

Access Changes
User maschad:
  - will gain push permission to js-libp2p-examples
User sgtpooki:
  - will gain push permission to js-libp2p-examples
User wemeetagain:
  - will gain push permission to js-libp2p-examples
User whizzzkid:
  - will gain push permission to js-libp2p-examples

Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

Comment on lines 3491 to 3493
admin:
- Admin
- SgtPooki
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I be in maintain, or should we add team shipyard?

github/libp2p.yml Outdated Show resolved Hide resolved
github/libp2p.yml Outdated Show resolved Hide resolved
Copy link
Contributor

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # github_team_repository.this["js-libp2p-dev:js-libp2p-examples"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "push"
      + repository = "js-libp2p-examples"
      + team_id    = "8478585"
    }

Plan: 1 to add, 0 to change, 0 to destroy.

@p-shahi p-shahi merged commit a028c39 into libp2p:master Sep 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants