-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add p-shahi to Repos Go & JS and Shipyard #247
Conversation
The following access changes will be introduced as a result of applying the plan: Access Changes
|
Before merge, verify that all the following plans are correct. They will be applied as-is after the merge. Terraform planslibp2p
|
@p-shahi could you restore the original formatting, there's a bunch of whitespace changes added to the PR. Otherwise for the practical aspects LGTM |
@aschmahmann that's VScode removing trailing whitespaces. Would you like me to remove those? |
I don't feel strongly. Only looking on my phone right now so can't tell what kind of whitespace changes (e.g. doing ones that'll just show up again when someone on a different OS or with a different IDE does the next PR would be bad, but if it's just a cleanup then 👍). |
Yes its a cleanup! I need your stamp before I can merge. |
Unfortunately I can't help you as my permissions were removed here (Marco also has no permissions). cc @libp2p/github-mgmt-stewards who do have permissions |
Summary
Push access to Repos Go and JS
Follow up to #245
DRI: myself
Reviewer's Checklist