Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add p-shahi to Repos Go & JS and Shipyard #247

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

p-shahi
Copy link
Member

@p-shahi p-shahi commented Aug 15, 2024

Summary

Push access to Repos Go and JS

Follow up to #245

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@p-shahi p-shahi requested review from a team as code owners August 15, 2024 16:47
Copy link
Contributor

github-actions bot commented Aug 15, 2024

The following access changes will be introduced as a result of applying the plan:

Access Changes
User p-shahi:
  - will have the permission to go-libp2p change from pull to maintain
  - will have the permission to js-libp2p change from pull to maintain

Copy link
Contributor

github-actions bot commented Aug 15, 2024

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # github_team_membership.this["repos - go:p-shahi"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "2100801"
      + username = "p-shahi"
    }

  # github_team_membership.this["repos - javascript:p-shahi"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "2120753"
      + username = "p-shahi"
    }

  # github_team_membership.this["shipyard:p-shahi"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "10765583"
      + username = "p-shahi"
    }

Plan: 3 to add, 0 to change, 0 to destroy.

@p-shahi p-shahi changed the title chore: add p-shahi to Repos Go & JS chore: add p-shahi to Repos Go & JS and Shipyard Aug 16, 2024
@aschmahmann
Copy link
Contributor

@p-shahi could you restore the original formatting, there's a bunch of whitespace changes added to the PR.

Otherwise for the practical aspects LGTM

@p-shahi
Copy link
Member Author

p-shahi commented Aug 19, 2024

@aschmahmann that's VScode removing trailing whitespaces. Would you like me to remove those?

@aschmahmann
Copy link
Contributor

I don't feel strongly. Only looking on my phone right now so can't tell what kind of whitespace changes (e.g. doing ones that'll just show up again when someone on a different OS or with a different IDE does the next PR would be bad, but if it's just a cleanup then 👍).

@p-shahi
Copy link
Member Author

p-shahi commented Aug 19, 2024

Yes its a cleanup! I need your stamp before I can merge.

@aschmahmann
Copy link
Contributor

Unfortunately I can't help you as my permissions were removed here (Marco also has no permissions). cc @libp2p/github-mgmt-stewards who do have permissions

@galargh galargh merged commit a3ef9c4 into master Aug 20, 2024
6 checks passed
@dhuseby dhuseby deleted the add-pshahi-repos-go-js branch August 27, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants