Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use github-mgmt stewards for non-admin management of github-mgmt #246

Merged

Conversation

aschmahmann
Copy link
Contributor

@aschmahmann aschmahmann commented Aug 13, 2024

Summary

This cleans up some duplicated permissions that don't seem necessary and puts github-mgmt stewards modifications back under github-mgmt control (with the exception of ipdx and org admins).

Why do you need this?

  • Deduplication: Just seems like a reasonable idea
  • Removing maintainer on github-mgmt stewards: It says to do so in the YAML
    • Seems to have been reverted by an auto-update which might've happened while @dhuseby had admin permissions

What else do we need to know?

cc @dhuseby @p-shahi in case there was a reason things ended up like this

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@aschmahmann aschmahmann requested review from a team as code owners August 13, 2024 21:37
Copy link
Contributor

The following access changes will be introduced as a result of applying the plan:

Access Changes
There will be no access changes

Comment on lines +5095 to +5097
# Why @dhuseby?
# 1. Project community leader interfacing with multiple implementation teams.
- dhuseby
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grabbed text from this commit d2487f1, which is effectively being reverted here

Copy link
Contributor

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place
  - destroy

Terraform will perform the following actions:

  # github_repository_collaborator.this["github-mgmt:dhuseby"] will be destroyed
  # (because key ["github-mgmt:dhuseby"] is not in for_each map)
  - resource "github_repository_collaborator" "this" {
      - id         = "github-mgmt:dhuseby" -> null
      - permission = "push" -> null
      - repository = "github-mgmt" -> null
      - username   = "dhuseby" -> null
    }

  # github_repository_collaborator.this["github-mgmt:p-shahi"] will be destroyed
  # (because key ["github-mgmt:p-shahi"] is not in for_each map)
  - resource "github_repository_collaborator" "this" {
      - id         = "github-mgmt:p-shahi" -> null
      - permission = "push" -> null
      - repository = "github-mgmt" -> null
      - username   = "p-shahi" -> null
    }

  # github_team_membership.this["github-mgmt stewards:dhuseby"] will be updated in-place
  ~ resource "github_team_membership" "this" {
        id       = "6630941:dhuseby"
      ~ role     = "maintainer" -> "member"
        # (3 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 2 to destroy.

@galargh galargh merged commit 1494e81 into libp2p:master Aug 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants