generated from ipdxco/github-as-code
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use github-mgmt stewards for non-admin management of github-mgmt #246
Merged
galargh
merged 4 commits into
libp2p:master
from
aschmahmann:permissions/github-mgmt-root-and-stewards
Aug 20, 2024
Merged
use github-mgmt stewards for non-admin management of github-mgmt #246
galargh
merged 4 commits into
libp2p:master
from
aschmahmann:permissions/github-mgmt-root-and-stewards
Aug 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following access changes will be introduced as a result of applying the plan: Access Changes
|
aschmahmann
commented
Aug 13, 2024
Comment on lines
+5095
to
+5097
# Why @dhuseby? | ||
# 1. Project community leader interfacing with multiple implementation teams. | ||
- dhuseby |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grabbed text from this commit d2487f1, which is effectively being reverted here
Before merge, verify that all the following plans are correct. They will be applied as-is after the merge. Terraform planslibp2p
|
p-shahi
approved these changes
Aug 15, 2024
MarcoPolo
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This cleans up some duplicated permissions that don't seem necessary and puts github-mgmt stewards modifications back under github-mgmt control (with the exception of ipdx and org admins).
Why do you need this?
What else do we need to know?
cc @dhuseby @p-shahi in case there was a reason things ended up like this
DRI: myself
Reviewer's Checklist