Use default zone TTL #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Hetzner DNS API returns a default TTL field for every zone.
Based on this, records that use a non-custom TTL will not include the
ttlfield at all in their JSON representation and thus result in alibdns.Recordobject with a TTL of 0 seconds.This PR solves this by enhancing the existent
getZoneID(renamed togetZoneData) to not only return the zone's ID but also its default TTL.It also updates the unmarshalling step of a JSON record returned by the Hetzner API to use this default TTL when the
ttlfield does not exist.