Prefill ALLEGRO_AUDIO_STREAMs with data in docstrings/examples/acodec. #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The audio system will attempt to grab data from a stream *before* it has sent any events that it needs fragments. This causes a bit of lag, and also log spam as the system complains about having no data. This change adjusts most places to prefill the streams with data to avoid this issue. It should be safe, and in fact beneficial as we should get a few less sample-worths of lag when using `al_play/load_audio_stream`.
SiegeLord
force-pushed
the
prefil_stream
branch
from
0e7c9bd
to
c0eaf70
Compare
|
Is there a case where you wouldn't want to pre-fill, i.e can this be the default? |
|
The data needs to come from somewhere, it's not appropriate for it to always be silence. So, there's no case where you don't want to prefill, but there's also no way to have a default prefilling code. An alternative to this would be to somehow have stream start out as paused, have it send the event, have it unpause when it gets the first fragment. It's not obvious that that's a better solution, since it introduces some additional lag, in principle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The audio system will attempt to grab data from a stream before it has sent any events that it needs fragments. This causes a bit of lag, and also log spam as the system complains about having no data.
This change adjusts most places to prefill the streams with data to avoid this issue. It should be safe, and in fact beneficial as we should get a few less sample-worths of lag when using
al_play/load_audio_stream.