Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 4byte rgb format #770

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaichi-oda-tiv
Copy link
Contributor

It didn't support import "FIELD X Y Z RGB" so we fixed it.

@EricBoiseLGSVL
Copy link
Contributor

@hadiTab

}
else if (ColorF != null)
{
var ptr = (byte*)ColorF + index * Stride;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If field type is float then why this ptr is read as 3 bytes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, I've only seen data in which 32bit is forcibly packed with 8bit rgb value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants