Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieving BridgePlugin by name, not a type #1638

Open
wants to merge 1 commit into
base: release-2021.2
Choose a base branch
from

Conversation

pijaro
Copy link
Contributor

@pijaro pijaro commented Jul 28, 2021

BridgePlugins.Get(...) expects a name of a bridge, not its type.

This fixes resolving a correct BridgePlugin for custom bridges whose type != name (accidentally every SVL core bridge name matches its type).

Signed-off-by: Piotr Jaroszek <[email protected]>
@pijaro
Copy link
Contributor Author

pijaro commented Jul 29, 2021

One more thing to mention, BridgeData.Name is a name of asset in web gui, not an attribute name. This rises further problems when web-gui asset name (set by user when deploying asset) is different than attribute name in cs file.

@pijaro
Copy link
Contributor Author

pijaro commented Aug 17, 2021

@zelenkovsky Can you look into this, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant