Context-aware "use" completions #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this is intended to land after we get 0.3 out. |
When using `use`, we would complete any module, even those without `__using__` macros defined. This PR filters any suggestions inside a `use` directive to ensure that any suggested modules (or a submodule) contain a __using__ macro of arity 1. One thing that cropped up is that not all modules are loaded when queried, so I had to use `:code.all_available` to generate the module list. This wasn't super duper fast, so I had to put a cache in front of it, which is the large part of this PR. Another oddity is that I couldn't just send anonymous functions as predicates, so I had to come up with a way to implement filtering logic across distribution, so I did a matchspec-like thingy, which was a bit ugly, so I made some syntax to make it look like function captures.
scohen
force-pushed
the
context-aware-use
branch
from
9fed5c9
to
8760b80
Compare
scottming
approved these changes
Aug 16, 2023
|
I tried this branch, works great. BTW, Perhaps it is unrelated to this PR, but should we let I mean: 
|
|
Agree with your screenshot, we should emit a snippet |
scohen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
use, we would complete any module, even those without__using__macros defined.This PR filters any suggestions inside a
usedirective to ensure that any suggested modules (or a submodule) contain a using macro of arity 1.One thing that cropped up is that not all modules are loaded when queried, so I had to use
:code.all_availableto generate the module list. This wasn't super duper fast, so I had to put a cache in front of it, which is the large part of this PR.Another oddity is that I couldn't just send anonymous functions as predicates, so I had to come up with a way to implement filtering logic across distribution, so I did a matchspec-like thingy, which was a bit ugly, so I made some syntax to make it look like function captures.
Fixes #330