Support for HEEx compilation #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottming
force-pushed
the
support-heex-compilation
branch
from
adc5a4f
to
16bca48
Compare
scottming
commented
Aug 14, 2023
apps/remote_control/lib/lexical/remote_control/build/document/compilers/heex.ex
Outdated
Show resolved
Hide resolved
scottming
force-pushed
the
support-heex-compilation
branch
3 times, most recently
from
e988515
to
fc14a23
Compare
scottming
force-pushed
the
support-heex-compilation
branch
from
e47be3d
to
94163f0
Compare
generated by `mix new live_demo`, then add the `liveview` deps
It's like peeling an onion. When we have an HEEx file, we first use the HTML engine to transform and compile it. Once the part that belongs to HTML is fine, we then use the EEx engine to transform it, evaluate it, and finally compile it.
This reverts commit 570097f.
scottming
force-pushed
the
support-heex-compilation
branch
from
94163f0
to
65ed9f0
Compare
scottming
force-pushed
the
support-heex-compilation
branch
from
65ed9f0
to
472e072
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts an approach that divides the compilation of HEEx into three steps. First, it focuses on the HTML portion, then the EEx part, where certain errors in EEx require evaluation to obtain, and finally, the compile_quoted step.
I think this layered approach is quite good, like peeling an onion.
Though there are some problems that I haven't thought of a good solution for now, such as
mix compilewill emit an error, but how can this be achieved for single file compilation? Jose suggested that we compile the relevantexfiles directly, but it seems difficult because the latest content of those files may only exist in theDocument.Storeof the server node..exfile, likecore_components.ex, how can the~Hblock be compiled separately?~pblock in a~Hblock orHEExfile.DEMO
as-you-type compilation
CleanShot.2023-08-13.at.17.51.35-trimmed.mp4
after saving
CleanShot.2023-08-13.at.17.51.35.mp4