Fix: Flaky tests #320
Merged
Fix: Flaky tests #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two tests in this app were stomping on each others' configurations, and would occasionally cause spurious messages to be sent to one another. Deregistering and clearing config on exit fixes the problems I also made the project URI a little more "real"
The property test would occasionally fail with a "TooManyDuplicatesError". I bumped up the initial generation size to 50 and picked the ranges from a larger list, which seems to have alleviated the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of our flaky unit tests. Thank you to whomever put the seed in the output of ExUnit, that was what was needed to reproduce the flakiness.
Fixes #279