Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for erlang 26 #319

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Support for erlang 26 #319

merged 1 commit into from
Aug 12, 2023

Conversation

scohen
Copy link
Collaborator

@scohen scohen commented Aug 11, 2023

I tried erlang 26.0.2, and lo and behold, it worked with lexical. There were a few unit test failures due to completion results being ordered differently, but otherwise, lexical works great under 26.

Fixes #244

@scohen scohen requested a review from scottming August 11, 2023 18:23
@scohen scohen force-pushed the erlang_26 branch 2 times, most recently from aab091b to 0d7ffca Compare August 11, 2023 21:21
@scohen scohen changed the base branch from main to flaky_tests August 11, 2023 21:21
@scohen scohen force-pushed the erlang_26 branch 2 times, most recently from de7d16a to 81fe1b0 Compare August 11, 2023 21:36
Base automatically changed from flaky_tests to main August 11, 2023 21:51
I tried erlang 26.0.2, and lo and behold, it worked with
lexical. There were a few unit test failures due to completion results
being ordered differently, but otherwise, lexical works great under
26.

Fixes #244
@scottming
Copy link
Collaborator

Today, when I was trying version 26, I found that:

  1. If Lexical is packaged with version 26 while the project is version 25, we won't be able to start Lexical.
  2. There are no issues if Lexical is packaged with version 25 while the project is version 26.
  3. There are no issues if Lexical is packaged with version 26 and the project is also version 26.

We may need to make a note of this in the documentation.

And this is the error:

~/Code/dummy master ?7 ❯ /Users/scottming/Code/lexical/_build/dev/package/lexical/bin/start_lexical.sh

11:08:40.826 [error] beam/beam_load.c(190): Error loading module 'Elixir.LoggerFileBackend':
  This BEAM file was compiled for a later version of the runtime system than the current (Erlang/OTP 25).
  To fix this, please re-compile this module with an Erlang/OTP 25 compiler.
  (Use of opcode 182; this emulator supports only up to 180.)



11:08:40.826 [error] Loading of /Users/scottming/Code/lexical/_build/dev/package/lexical/bin/../lib/logger_file_backend.ez/logger_file_backend/ebin/Elixir.LoggerFileBackend.beam failed: :badfile


11:08:40.842 [error] Loading of /Users/scottming/Code/lexical/_build/dev/package/lexical/bin/../lib/lx_sourceror.ez/lx_sourceror/ebin/Elixir.LXSourceror.beam failed: :badfile


11:08:40.842 [error] beam/beam_load.c(190): Error loading module 'Elixir.LXSourceror':
  This BEAM file was compiled for a later version of the runtime system than the current (Erlang/OTP 25).
  To fix this, please re-compile this module with an Erlang/OTP 25 compiler.
  (Use of opcode 182; this emulator supports only up to 180.)


** (ArgumentError) could not load module LXSourceror due to reason :badfile
    (elixir 1.15.4) lib/code.ex:1779: Code.ensure_loaded!/1
    (elixir 1.15.4) lib/enum.ex:984: Enum."-each/2-lists^foreach/1-0-"/2
    lib/lexical/server/boot.ex:17: LXical.Server.Boot.start/0
    nofile:1: (file)
    (stdlib 4.3.1.2) erl_eval.erl:748: :erl_eval.do_apply/7
    ```

@scohen
Copy link
Collaborator Author

scohen commented Aug 12, 2023

I believe that the documentation makes this clear in the detailed installation instructions

@scohen scohen merged commit 4d1edce into main Aug 12, 2023
6 checks passed
@scohen scohen deleted the erlang_26 branch August 12, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Erlang 26
2 participants