Added support for per-file .eex compilation #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor / improvement of per-file compilation. Prior, we were just shunting all files into the the elixir compiler, but as it turns out, there are other types of files that need to be compiled. This PR makes a compiler behaviour, and three implementations: elixir, eex and no-op.
scottming
reviewed
Jul 29, 2023
apps/remote_control/lib/lexical/remote_control/build/document/compilers/quoted.ex
Outdated
Show resolved
Hide resolved
scohen
force-pushed
the
support-eex-compilation
branch
from
c946b65
to
16ea9cf
Compare
scottming
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor / improvement of per-file compilation. Prior, we were just shunting all files into the the elixir compiler, but as it turns out, there are other types of files that need to be compiled. This PR makes a compiler behaviour, and three implementations: elixir, eex and no-op.