Removed plugin_runner app (#327)

Removed plugin_runner app and moved its functionality into remote
control. The plugin runner app was due to expediency when that
functionality was in `lexical_plugin` and I thought that it would be
easier to put it in its own app.
Nah, just put it in remote_control

apps/remote_control/lib/lexical/remote_control/application.ex

@@ -15,7 +15,9 @@ defmodule Lexical.RemoteControl.Application do
           RemoteControl.ModuleMappings,
           RemoteControl.Build,
           RemoteControl.Build.CaptureServer,
-          RemoteControl.Compilation.Dispatch
+          RemoteControl.Compilation.Dispatch,
+          RemoteControl.Plugin.Runner.Supervisor,
+          RemoteControl.Plugin.Runner.Coordinator
         ]
       else
         []

apps/remote_control/lib/lexical/remote_control/plugin.ex

@@ -1,9 +1,9 @@
 defmodule Lexical.RemoteControl.Plugin do
   alias Lexical.Document
-  alias Lexical.Plugin.Runner
   alias Lexical.Project
   alias Lexical.RemoteControl
   alias Lexical.RemoteControl.Api.Messages
+  alias Lexical.RemoteControl.Plugin.Runner
 
   import Messages
 

apps/remote_control/lib/lexical/remote_control/plugin/discovery.ex

@@ -10,7 +10,7 @@ defmodule Lexical.RemoteControl.Plugin.Discovery do
   and the plugin will crash.
   """
 
-  alias Lexical.Plugin.Runner
+  alias Lexical.RemoteControl.Plugin.Runner
   alias Mix.Tasks.Namespace
 
   require Logger

apps/plugin_runner/lib/lexical/plugin/runner.ex → apps/remote_control/lib/lexical/remote_control/plugin/runner.ex

@@ -1,9 +1,9 @@
-defmodule Lexical.Plugin.Runner do
+defmodule Lexical.RemoteControl.Plugin.Runner do
   @moduledoc false
 
   alias Lexical.Document
-  alias Lexical.Plugin.Runner
   alias Lexical.Project
+  alias Lexical.RemoteControl.Plugin.Runner
 
   require Logger
 

apps/plugin_runner/lib/lexical/plugin/runner/coordinator.ex → apps/remote_control/lib/lexical/remote_control/plugin/runner/coordinator.ex

@@ -1,8 +1,8 @@
-defmodule Lexical.Plugin.Runner.Coordinator do
+defmodule Lexical.RemoteControl.Plugin.Runner.Coordinator do
   @moduledoc false
 
   alias Lexical.Formats
-  alias Lexical.Plugin.Runner.Coordinator.State
+  alias Lexical.RemoteControl.Plugin.Runner.Coordinator.State
 
   require Logger
   use GenServer

apps/plugin_runner/lib/lexical/plugin/coordinator/state.ex → apps/remote_control/lib/lexical/remote_control/plugin/runner/coordinator/state.ex

@@ -1,7 +1,7 @@
-defmodule Lexical.Plugin.Runner.Coordinator.State do
+defmodule Lexical.RemoteControl.Plugin.Runner.Coordinator.State do
   @moduledoc false
 
-  alias Lexical.Plugin.Runner
+  alias Lexical.RemoteControl.Plugin.Runner
 
   defstruct tasks: [], failures: %{}
 

apps/plugin_runner/lib/lexical/plugin/supervisor.ex → apps/remote_control/lib/lexical/remote_control/plugin/supervisor.ex

@@ -1,4 +1,4 @@
-defmodule Lexical.Plugin.Runner.Supervisor do
+defmodule Lexical.RemoteControl.Plugin.Runner.Supervisor do
   @moduledoc false
 
   def child_spec(_) do

apps/remote_control/lib/mix/tasks/namespace.ex

@@ -23,7 +23,6 @@ defmodule Mix.Tasks.Namespace do
     "proto" => "Lexical",
     "protocol" => "Lexical",
     "remote_control" => "Lexical",
-    "plugin_runner" => "Lexical",
     "server" => "Lexical"
   }
 

apps/remote_control/mix.exs

@@ -38,7 +38,6 @@ defmodule Lexical.RemoteControl.MixProject do
       {:lexical_test, path: "../../projects/lexical_test", only: :test},
       {:lexical_plugin, path: "../../projects/lexical_plugin"},
       {:common, in_umbrella: true},
-      {:plugin_runner, in_umbrella: true},
       {:elixir_sense, git: "https://github.com/elixir-lsp/elixir_sense.git"},
       {:patch, "~> 0.12", only: [:dev, :test], optional: true, runtime: false},
       {:path_glob, "~> 0.2", optional: true},

apps/remote_control/test/lexical/remote_control/build/state_test.exs

@@ -4,6 +4,7 @@ defmodule Lexical.RemoteControl.Build.StateTest do
   alias Lexical.RemoteControl
   alias Lexical.RemoteControl.Build
   alias Lexical.RemoteControl.Build.State
+  alias Lexical.RemoteControl.Plugin
 
   import Lexical.Test.EventualAssertions
   import Lexical.Test.Fixtures
@@ -14,8 +15,8 @@ defmodule Lexical.RemoteControl.Build.StateTest do
   setup do
     {:ok, _} = start_supervised(Build.CaptureServer)
     {:ok, _} = start_supervised(RemoteControl.ModuleMappings)
-    {:ok, _} = start_supervised(Lexical.Plugin.Runner.Coordinator)
-    {:ok, _} = start_supervised(Lexical.Plugin.Runner.Supervisor)
+    {:ok, _} = start_supervised(Plugin.Runner.Coordinator)
+    {:ok, _} = start_supervised(Plugin.Runner.Supervisor)
     :ok
   end
 
@@ -81,7 +82,7 @@ defmodule Lexical.RemoteControl.Build.StateTest do
     test "it compiles after a timeout", %{state: state, document: document} do
       state = State.on_file_compile(state, document)
 
-      refute_eventually State.compile_scheduled?(State.on_tick(state), document.uri), 500
+      refute_eventually(State.compile_scheduled?(State.on_tick(state), document.uri), 500)
     end
   end
 end

apps/plugin_runner/test/lexical/plugin/runner/coordinator/state_test.exs → apps/remote_control/test/lexical/remote_control/plugin/runner/coordinator/state_test.exs

@@ -1,8 +1,8 @@
-defmodule Lexical.Plugin.Coordinator.StateTest do
+defmodule Lexical.RemoteControl.Plugin.Coordinator.StateTest do
   alias Lexical.Document
-  alias Lexical.Plugin.Runner
-  alias Lexical.Plugin.Runner.Coordinator.State
   alias Lexical.Plugin.V1
+  alias Lexical.RemoteControl.Plugin.Runner
+  alias Lexical.RemoteControl.Plugin.Runner.Coordinator.State
 
   use ExUnit.Case
 

apps/plugin_runner/test/lexical/plugin/runner/coordinator_test.exs → apps/remote_control/test/lexical/remote_control/plugin/runner/coordinator_test.exs

@@ -1,7 +1,7 @@
-defmodule Lexical.Runner.CoordinatorTest do
+defmodule Lexical.RemoteControl.Plugin.Runner.CoordinatorTest do
   alias Lexical.Document
-  alias Lexical.Plugin.Runner
   alias Lexical.Project
+  alias Lexical.RemoteControl.Plugin.Runner
 
   use ExUnit.Case, async: false
   import Lexical.Test.EventualAssertions