Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modification caching; Constant terminal mods for ProForma #148

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

mobiusklein
Copy link
Contributor

Modification caching

All ModificationResolver types now use an in-memory cache for resolved modification definitions, reducing overhead of resolving the same rule over and over again.

Sub-classes should move their implementation of resolve to the _resolve_impl method, otherwise the cache will not be used.

To disable the cache for a resolver instance, call resolver.enable_caching(False).

Constant terminal modifications

This implements support for the syntax discussed in HUPO-PSI/ProForma#6 to include constant modification rules that apply to specific sequence terminals with or without specific amino acids.

**Modification caching**
All ModificationResolver types now use an in-memory cache for
resolved modification definitions, reducing overhead of resolving
the same rule over and over again.

Sub-classes should move their implementation of `resolve` to the
`_resolve_impl` method, otherwise the cache will not be used.

To disable the cache for a resolver instance, call `resolver.enable_caching(False)`.

**Constant terminal modifications**
This implements support for the syntax discussed in HUPO-PSI/ProForma#6
to include constant modification rules that apply to specific sequence
terminals with or without specific amino acids.
@mobiusklein mobiusklein changed the title Add modification caching; Constant terminal mods; Add modification caching; Constant terminal mods for ProForma Apr 20, 2024
@levitsky levitsky merged commit a2dc74d into levitsky:master Apr 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants