Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve profiles #228

Merged
merged 7 commits into from
Oct 23, 2024
Merged

Improve profiles #228

merged 7 commits into from
Oct 23, 2024

Conversation

aarongable
Copy link
Contributor

@aarongable aarongable commented Sep 26, 2024 •
edited
Loading

  • Remove OCSP Delegated Responder profile, as we no longer issue such certificates
  • Remove restrictions on the Common Names we set
  • Remove restriction on ECDSA P-521
  • Improve descriptions of key sizes and checking routines
  • Improve descriptions of algorithm identifiers
  • Miscellaneous formatting and phrasing improvements

Fixes #185
Fixes #196
Fixes #212
Fixes #213
Fixes #217
Fixes #218

@aarongable
Improve profiles
c1aa671 
- Remove OCSP Delegated Responder profile, as we no longer issue such certificates
- Remove restrictions on the Common Names we set
- Remove restriction on ECDSA P-521
- Miscellaneous formatting and phrasing improvements

Fixes #185
Fixes #196
Fixes #212
Fixes #217
Fixes #218
@aarongable aarongable mentioned this pull request Sep 26, 2024
Closed
@aarongable aarongable added this to the Q3 2024 milestone Sep 27, 2024
jprenken
jprenken reviewed Sep 27, 2024
View reviewed changes
CP-CPS.md Outdated Show resolved Hide resolved
@aarongable
Copy link
Contributor Author

Let's hold on this one for a sec, I have a further improvement in the works.

beautifulentropy
beautifulentropy requested changes Oct 22, 2024
View reviewed changes
CP-CPS.md Outdated Show resolved Hide resolved
CP-CPS.md Outdated Show resolved Hide resolved
CP-CPS.md Outdated Show resolved Hide resolved
@aarongable @beautifulentropy
Shorten links
628b701 
Co-authored-by: Samantha Frank <[email protected]>
jsha
jsha reviewed Oct 22, 2024
View reviewed changes
CP-CPS.md Outdated Show resolved Hide resolved
jsha
jsha requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment in this review, and also one I previously left as an independent comment: https://github.com/letsencrypt/cp-cps/pull/228/files?w=1#r1811208144

CP-CPS.md Outdated Show resolved Hide resolved
@aarongable aarongable requested a review from jsha October 22, 2024 22:45
@aarongable aarongable merged commit 70910b1 into main Oct 23, 2024
3 checks passed
@aarongable aarongable deleted the aarongable-patch-1 branch October 23, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdaehlie bdaehlie bdaehlie approved these changes

@jsha jsha jsha approved these changes

@jprenken jprenken jprenken approved these changes

@beautifulentropy beautifulentropy beautifulentropy approved these changes

@andygabby andygabby Awaiting requested review from andygabby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No Meaningful Subject Distinguished N...
6 participants
@aarongable @bdaehlie @jsha @andygabby @jprenken @beautifulentropy