ratelimits: Update errors to deep link to individual limits documentation #7767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beautifulentropy
force-pushed
the
update-limits-docs
branch
from
b9748fe
to
10683e8
Compare
beautifulentropy
changed the title
beautifulentropy
added a commit
to letsencrypt/website
that referenced
this pull request
Oct 23, 2024
#1755) Reverts #1754 Reverting these docs updates until the old URLs replaced in letsencrypt/boulder#7767 are deployed to production.
beautifulentropy
force-pushed
the
update-limits-docs
branch
from
10683e8
to
efdbb45
Compare
beautifulentropy
changed the title
aarongable
approved these changes
Oct 24, 2024
| @@ -583,7 +599,7 @@ func TestRateLimitError(t *testing.T) { | |||
| test.AssertNotError(t, err, "expected no error") | |||
| } else { | |||
| test.AssertError(t, err, "expected an error") | |||
| test.AssertContains(t, err.Error(), tc.expectedErr) | |||
| test.AssertEquals(t, err.Error(), tc.expectedErr) | |||
There was a problem hiding this comment.
nit: I don't love using AssertEquals for error strings, it makes us a bit too precise imo. I'd prefer that the test case have two fields expectedErr and expectedLink, and assert that the resulting message contains both of them. But that's a super minor thing.
jprenken
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates rate limits error messages to deep link to new website docs added in letsencrypt/website#1756.
Reviewers, please check the links against the preview of these changes.